Skip to content

bpo-40950: Port nis module to multiphase initialization#20811

Merged
corona10 merged 9 commits into
python:masterfrom
corona10:bpo-40950
Jun 12, 2020
Merged

bpo-40950: Port nis module to multiphase initialization#20811
corona10 merged 9 commits into
python:masterfrom
corona10:bpo-40950

Conversation

@corona10
Copy link
Copy Markdown
Member

@corona10 corona10 commented Jun 11, 2020

Comment thread Modules/nismodule.c Outdated
Comment thread Modules/nismodule.c Outdated
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-06-12-00-12-28.bpo-40950.tzMy7m.rst Outdated
Comment thread Modules/nismodule.c Outdated
corona10 and others added 2 commits June 12, 2020 01:08
@corona10 corona10 requested a review from vstinner June 11, 2020 16:16
Copy link
Copy Markdown
Member Author

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner
Thanks for the review!
Updated!

Comment thread Modules/nismodule.c Outdated
Comment thread Modules/nismodule.c Outdated
Comment thread Modules/nismodule.c Outdated
@corona10 corona10 requested a review from vstinner June 11, 2020 17:43
@corona10
Copy link
Copy Markdown
Member Author

@shihai1991 Can you please take a look?

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread Modules/nismodule.c
@corona10 corona10 changed the title bpo-40950: Apply PEP 3121 to nis module bpo-40950: Port nis module to multiphase initialization Jun 12, 2020
@corona10 corona10 merged commit ddef3bd into python:master Jun 12, 2020
@corona10 corona10 deleted the bpo-40950 branch June 13, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants